Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical options String values double-length encoding #207

Merged
merged 5 commits into from Mar 22, 2024
Merged

Critical options String values double-length encoding #207

merged 5 commits into from Mar 22, 2024

Commits on Mar 21, 2024

  1. critical options' values are embedded strings and therefore have doub… 

    …le length encoding
    @jeromegn
    jeromegn committed Mar 21, 2024
    Copy the full SHA
    b2acf35 View commit details
    Browse the repository at this point in the history

  2. fix options map behavior for encoding as well

    @jeromegn
    jeromegn committed Mar 21, 2024
    Copy the full SHA
    3c6d594 View commit details
    Browse the repository at this point in the history

  3. addressed PR comments, much simpler

    @jeromegn
    jeromegn committed Mar 21, 2024
    Copy the full SHA
    02f3f83 View commit details
    Browse the repository at this point in the history

  4. remove some whitespace

    @jeromegn
    jeromegn committed Mar 21, 2024
    Copy the full SHA
    02971ca View commit details
    Browse the repository at this point in the history

  5. special-case 0-len critical option values

    @jeromegn
    jeromegn committed Mar 21, 2024
    Copy the full SHA
    c30eca7 View commit details
    Browse the repository at this point in the history