Make the string cache specific to each SBJsonStreamWriter, and make i…

…t an NSCache rather than NSMutableDictionary so the OS can reclaim memory if necessary. Should fix #55
SBJson · Apr 27, 2011 · a93f424 · a93f424
1 parent 39d1f46
commit a93f424
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Classes/SBJsonStreamWriter.h b/Classes/SBJsonStreamWriter.h
@@ -76,6 +76,7 @@
 	NSMutableData *data;
 	NSUInteger depth, maxDepth;
     BOOL sortKeys, humanReadable;
+    NSCache *stringCache;
 }
 
 /**

diff --git a/Classes/SBJsonStreamWriter.m b/Classes/SBJsonStreamWriter.m
@@ -33,7 +33,6 @@
 #import "SBJsonStreamWriter.h"
 #import "SBJsonStreamWriterState.h"
 
-static NSMutableDictionary *stringCache;
 static NSDecimalNumber *notANumber;
 
 @implementation SBJsonStreamWriter
@@ -47,7 +46,6 @@ @implementation SBJsonStreamWriter
 
 + (void)initialize {
 	notANumber = [NSDecimalNumber notANumber];
-	stringCache = [NSMutableDictionary new];
 }
 
 #pragma mark Housekeeping
@@ -61,7 +59,9 @@ - (id)init {
 		NSAssert(states, @"States not initialised");
 
 		states[0] = [SBJsonStreamWriterStateStart sharedInstance];
-	}
+
+		stringCache = [[NSCache alloc] init];
+    }
 	return self;
 }