Add content to cumulusci.yml Pydantic models and JSON Schema #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cumulusci.yml json schema to provide better help information in IDEs. Currently the test to compare the generated schema to the schema file is failing for reasons I can't understand yet, but the content is ready for review.
|
@jlantz Looks like the some test failures due to a schema mismatch. I'll push a copy of your branch to the remote to resolve the lint failure afterwards. |
yippie
reviewed
Jan 31, 2024
| max=30, | ||
| examples=[1, 7, 30], | ||
| ) | ||
| namespaced: bool = Field( |
There was a problem hiding this comment.
yay! the previous definition was wrong (claimed this was a str) and so YAML checking was failing in VSCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added title, description, and examples to all Pydantic models for the cumulusci.yml json schema to provide better help information in IDEs.
There are a few places where I added enums.