Skip to content

Commit

Permalink
Add TODO comment for commented convert_to_base
Browse files Browse the repository at this point in the history
To review changes submitted in SHA:
c166625 and currently disabled. Likely,
to be removed.
  • Loading branch information
mloskot committed Mar 2, 2013
1 parent e29813d commit fa05838
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/core/type-conversion.h
Expand Up @@ -86,6 +86,7 @@ class conversion_use_type
, ind_(ownInd_)
, readOnly_(false)
{
// TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8)
//convert_to_base();
}

Expand All @@ -95,6 +96,7 @@ class conversion_use_type
, ind_(ownInd_)
, readOnly_(true)
{
// TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8)
//convert_to_base();
}

Expand All @@ -105,6 +107,7 @@ class conversion_use_type
, ind_(ind)
, readOnly_(false)
{
// TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8)
//convert_to_base();
}

Expand All @@ -115,6 +118,7 @@ class conversion_use_type
, ind_(ind)
, readOnly_(true)
{
// TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8)
//convert_to_base();
}

Expand Down
2 changes: 1 addition & 1 deletion src/core/use-type.h
Expand Up @@ -50,7 +50,7 @@ class SOCI_DECL standard_use_type : public use_type_base
, backEnd_(NULL)
{
// FIXME: This was added with Ilia's patch
// http://soci.git.sourceforge.net/git/gitweb.cgi?p=soci/soci;a=blobdiff;f=src/core/use-type.h;h=3510ac95fe7530f977bf9e78d74fd502164a4071;hp=b6d9ba9c27aef3640b8edac4b8e44a620b1b5294;hb=c166625a28f7c907318134f625ff5acea7d9a1f8;hpb=ec19564b2f0994b3960acf891643d92fc224b453
// https://github.com/SOCI/soci/commit/c166625a28f7c907318134f625ff5acea7d9a1f8
// but it seems to be a troublemaker, causing duplicated conversions
//convert_to_base();
}
Expand Down

0 comments on commit fa05838

Please sign in to comment.