Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two possible issues with std::list serialization #1900

Closed
dmarce1 opened this issue Dec 8, 2015 · 3 comments · Fixed by #1904
Closed

Two possible issues with std::list serialization #1900

dmarce1 opened this issue Dec 8, 2015 · 3 comments · Fixed by #1904

Comments

@dmarce1
Copy link
Member

dmarce1 commented Dec 8, 2015

I was tracking down a bug in Octotiger related to serialization of std::list. When I replaced my std::lists with std::vectors, the problem went away, and I figured the std::lists being passed to remote localities were somehow losing elements.

  1. I noticed that line 22 in the list serialization:
    https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/serialization/list.hpp
    would cause a bug if the argument "ls" is not already an empty list.

  2. I figured out 1) was not causing the error with my program - turns out out hpx/runtime/serialization/list.hpp wasn't being included in the compile. I can't figure out how list was getting serialized without including the list.hpp header, but when I included the proper header the bug was fixed. I wasn't including the boost::serialization version anywhere in my source. Is the boost version of std::list serialization somewhere in the hpx headers, or is it possible the std::list was being automatically converted to another container improperly?

@hkaiser hkaiser added this to the 0.9.12 milestone Dec 8, 2015
@hkaiser
Copy link
Member

hkaiser commented Dec 8, 2015

@AntonBikineev is that something you can answer?

@hkaiser
Copy link
Member

hkaiser commented Dec 8, 2015

@dmarce1 The problem 1) you listed is a genuine bug. I'll fix this asap.

@hkaiser
Copy link
Member

hkaiser commented Dec 9, 2015

Issue 1) has been fixed by 9d604e4 (see #1904)
Issue 2) will be fixed by merging #1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants