Add missing specializations in execution policies #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| template <typename Executor, typename Parameters> | ||
| struct is_parallel_execution_policy<parallel_task_execution_policy_shim<Executor, Parameters>> | ||
| : std::true_type | ||
| {}; | ||
| /// \endcond |
There was a problem hiding this comment.
The parallel_task_... policies are 'parallel' as well. Could you add those while you're at it as well, please?
There was a problem hiding this comment.
Now 'parallel' are parallel, parallel_shim, parallel_task, parallel_task_shim and parallel_vector.
Which other am I missing in is_parallel_execution_policy? Or did you mean something else by 'add'?
There was a problem hiding this comment.
It was already there, I think the diff was misleading ;-)
|
Inspect is not happy with your changes: https://circle-artifacts.com/gh/STEllAR-GROUP/hpx/3716/artifacts/0/tmp/circle-artifacts.87XsJ13/hpx_inspect_report.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper support for rebounded policies.