New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing specializations in execution policies #2141
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1410,6 +1410,12 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |
: std::true_type | ||
{}; | ||
|
||
template <typename Executor, typename Parameters> | ||
struct is_parallel_execution_policy< | ||
parallel_execution_policy_shim<Executor, Parameters>> | ||
: std::true_type | ||
{}; | ||
|
||
template <> | ||
struct is_parallel_execution_policy<parallel_vector_execution_policy> | ||
: std::true_type | ||
|
@@ -1419,6 +1425,12 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |
struct is_parallel_execution_policy<parallel_task_execution_policy> | ||
: std::true_type | ||
{}; | ||
|
||
template <typename Executor, typename Parameters> | ||
struct is_parallel_execution_policy< | ||
parallel_task_execution_policy_shim<Executor, Parameters>> | ||
: std::true_type | ||
{}; | ||
/// \endcond | ||
} | ||
|
||
|
@@ -1508,10 +1520,22 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |
: std::true_type | ||
{}; | ||
|
||
template <typename Executor, typename Parameters> | ||
struct is_async_execution_policy< | ||
sequential_task_execution_policy_shim<Executor, Parameters> > | ||
: std::true_type | ||
{}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You probably wanted to add the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My mistake, fixed! |
||
|
||
template <> | ||
struct is_async_execution_policy<parallel_task_execution_policy> | ||
: std::true_type | ||
{}; | ||
|
||
template <typename Executor, typename Parameters> | ||
struct is_async_execution_policy< | ||
parallel_task_execution_policy_shim<Executor, Parameters> > | ||
: std::true_type | ||
{}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, should read There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My mistake, fixed! |
||
/// \endcond | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
parallel_task_...
policies are 'parallel' as well. Could you add those while you're at it as well, please?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now 'parallel' are parallel, parallel_shim, parallel_task, parallel_task_shim and parallel_vector.
Which other am I missing in is_parallel_execution_policy? Or did you mean something else by 'add'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I meant, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already there, I think the diff was misleading ;-)