Making sure multiple components are properly initialized from arguments #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Sep 17, 2016
hkaiser
commented
- this fixes Constructing a vector of components only correctly initializes the first component #2323
- added regression test
hkaiser
force-pushed
the
fixing_2323
branch
from
3fee29f
to
4f9d0de
Compare
sithhell
requested changes
Sep 18, 2016
- this fixes #2323 - added regression test
hkaiser
force-pushed
the
fixing_2323
branch
from
4f9d0de
to
6f2435e
Compare
|
@sithhell That should be fixed now, thanks! |
|
@sithhell Could you approve this PR, please? |
sithhell
approved these changes
Sep 21, 2016
K-ballo
reviewed
Sep 21, 2016
| @@ -651,9 +651,11 @@ namespace hpx { namespace components { namespace server | |||
| // Note, T and Ts can't be (non-const) references, and parameters | |||
| // should be moved to allow for move-only constructor argument | |||
| // types. | |||
There was a problem hiding this comment.
This note ought to be amended now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.