Add sync_images() method to spmd_block class #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrantan
force-pushed
the
spmd_block_with_sync_images
branch
5 times, most recently
from
dbbb12e
to
23dcaa9
Compare
atrantan
force-pushed
the
spmd_block_with_sync_images
branch
from
f03f154
to
02f8329
Compare
atrantan
force-pushed
the
spmd_block_with_sync_images
branch
from
02f8329
to
6faad89
Compare
hkaiser
approved these changes
Aug 9, 2017
|
@atrantan Would you be able to create some documentation for this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new method for
spmd_blockclass calledsync_images()to synchronize only a subset of images as opposed tosync_all(). The chosen approach is to manage concurrentlly amapof barriers that is expanded each time a new combination of image ids is given via async_images()call. Local and distributed versions have been implemented and unit tests have been changed to test those features.