Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault fix #3021

Merged
merged 18 commits into from Dec 7, 2017
Merged

Segfault fix #3021

merged 18 commits into from Dec 7, 2017

Conversation

ct-clmsn
Copy link
Contributor

work to decrease false positive rate on SIGSEGV

@hkaiser
Copy link
Member

hkaiser commented Nov 22, 2017

This is related to #2987

@hkaiser
Copy link
Member

hkaiser commented Dec 4, 2017

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Dec 5, 2017

@hkaiser for shame! thank you for the post! i've gone back and attempted to clean up all the formatting issues. hope to pass muster this go around.

@msimberg
Copy link
Contributor

msimberg commented Dec 5, 2017

@ct-clmsn One more here :)

/hpx/runtime/threads/coroutines/detail/context_linux_x86.hpp: *Line length limit*: 274

@msimberg
Copy link
Contributor

msimberg commented Dec 6, 2017

@ct-clmsn Thanks, looks good!

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Dec 6, 2017

@msimberg Thanks, I hope this works and minimizes the false positive rate to something more reasonable. Are there other things that I should do for the pycicle-Build pycicle-Test failures?

@hkaiser
Copy link
Member

hkaiser commented Dec 6, 2017

@ct-clmsn I think those can be ignored for now as they are unrelated to your work and will be fixed independently.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg msimberg merged commit d6f505c into STEllAR-GROUP:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants