Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler problem in MSVC release mode #3060

Merged
merged 1 commit into from Dec 15, 2017
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Dec 8, 2017

No description provided.

@sithhell
Copy link
Member

sithhell commented Dec 9, 2017

Which linker error did you get without that include?

@hkaiser
Copy link
Member Author

hkaiser commented Dec 9, 2017

Actually, it wasn't a linker error, sorry. I got a compilation error saying the type base_lco_with_value is incomplete here:

#if defined(HPX_MSVC) && !defined(HPX_DEBUG)
///////////////////////////////////////////////////////////////////////////
// Explicitly instantiate specific apply needed for set_lco_value for MSVC
// (in release mode only, leads to missing symbols otherwise).
template bool apply<
lcos::base_lco_with_value<
util::unused_type, util::unused_type
>::set_value_action,
util::unused_type
>(naming::id_type const &, util::unused_type &&);
#endif

@hkaiser hkaiser changed the title Fix linker problem in MSVC release mode Fix compiler problem in MSVC release mode Dec 9, 2017
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@msimberg msimberg merged commit 43292a2 into master Dec 15, 2017
@hkaiser hkaiser deleted the fixing_msvc_linking branch January 15, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants