Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hello_world_component to CI builds #3124

Closed
K-ballo opened this issue Jan 23, 2018 · 2 comments
Closed

Add hello_world_component to CI builds #3124

K-ballo opened this issue Jan 23, 2018 · 2 comments
Labels
category: buildbot category: examples category: tests
Milestone
1.1.0

Comments

@K-ballo
Copy link
Member

K-ballo commented Jan 23, 2018

hello_world_component is deliberately excluded from the cmake build as it is intended to illustrate building by command line. It should be explicitly added to CI builds, to prevent it from accidentally breaking.
@hkaiser hkaiser added this to the 1.1.0 milestone Jan 23, 2018
@NK-Nikunj
Copy link
Member

I'd like to take this issue up.

@hkaiser
Copy link
Member

hkaiser commented Feb 15, 2018

@NK-Nikunj absolutely, feel free.

NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Feb 17, 2018
@NK-Nikunj
Fixed issue STEllAR-GROUP#3124
ca921a3
@NK-Nikunj NK-Nikunj mentioned this issue Feb 17, 2018
Merged
NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Mar 4, 2018
@NK-Nikunj
Merge branch 'fix-STEllAR-GROUP#3124' of https://github.com/NK-Nikunj…
77c430b 
…/hpx into fix-STEllAR-GROUP#3124
NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Mar 8, 2018
@NK-Nikunj
Fix STEllAR-GROUP#3124: Build hello world client through make tests.u…
75ae9db 
…nit.build
NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Mar 8, 2018
@NK-Nikunj
Fix STEllAR-GROUP#3124: Build hello world client through make tests.u…
aa911fa 
…nit.build
NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Mar 8, 2018
@NK-Nikunj
Fix STEllAR-GROUP#3124: Build hello world client through make tests.u…
f49bd16 
…nit.build
NK-Nikunj added a commit to NK-Nikunj/hpx that referenced this issue Mar 8, 2018
@NK-Nikunj
Fix STEllAR-GROUP#3124: Build hello world client through make tests.u…
8aee503 
…nit.build
msimberg added a commit that referenced this issue Mar 13, 2018
@msimberg
Merge pull request #3178 from NK-Nikunj/fix-#3124
a281166 
Fix #3124
@msimberg msimberg mentioned this issue Mar 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: buildbot category: examples category: tests
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@hkaiser @K-ballo @NK-Nikunj