Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to CircleCI 2.0 #3036

Merged
merged 10 commits into from Mar 27, 2018
Merged

Switching to CircleCI 2.0 #3036

merged 10 commits into from Mar 27, 2018

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Dec 1, 2017

As prepared by @sithhell. This should have very high priority in order to get tests running on PRs.

@sithhell
Copy link
Member

sithhell commented Dec 1, 2017

Thanks for pushing that!

One thing we have to be aware of is that now, the circle checks will be flagged as failing, since we have lots of failing tests overall. But I think this is a good thing as it detects failures in PRs more easily and hopefully forces us to fix out tests.

@sithhell
Copy link
Member

sithhell commented Dec 1, 2017

The other thing is, there will only be a new docker image once all tests pass ;)

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections to merging this, thanks.

@msimberg
Copy link
Contributor Author

My remaining concern regarding this is that the header tests fail with "cannot allocate memory" and others. Should we disable them and try to get them running using pycicle or buildbot instead? We are not worse off disabling them as circleci 1 does not build them either now.

@hkaiser
Copy link
Member

hkaiser commented Jan 31, 2018

@msimberg the existing CircleCI tests do run the header tests and I wouldn't like to lose that.

@msimberg
Copy link
Contributor Author

@hkaiser Sorry, you're right. In that case that we should try to keep them running on circleci.

@msimberg
Copy link
Contributor Author

Putting this for reference here: CircleCI 1.0 will not be supported anymore after August 31st, 2018.

@msimberg msimberg force-pushed the circle_2 branch 3 times, most recently from 28f2eab to 1493fa4 Compare March 17, 2018 08:34
@msimberg msimberg force-pushed the circle_2 branch 2 times, most recently from c0e7cc9 to 5c14d76 Compare March 17, 2018 11:29
@msimberg
Copy link
Contributor Author

msimberg commented Mar 19, 2018

I played around a bit more and changed the following:

  • the header tests depend on the hpx target, so the header tests workflow steps now depend on the core step (the header tests were all rebuilding hpx from scratch)
  • for some inexplicable reason ninja caused the problems with "cannot allocate memory" and make had no problems, so I've changed the generator to Unix Makefiles (if someone has ideas on what ninja could possibly be doing differently I'd love to hear it)
  • build all parallel algorithms even if the partitioned vector tests fail

@msimberg msimberg removed this from the 1.1.0 milestone Mar 22, 2018
@msimberg
Copy link
Contributor Author

Any remaining concerns over this one?

@NK-Nikunj have I understood #3124 correctly that building the hello world component doesn't require any extra build steps now, and is part of tests/unit/build? I don't want to clobber your changes and end up with not building the hello world component again.

The only thing which fails now is building the partitioned vector tests which will show up red until they're fixed, but that we can live with.

@NK-Nikunj
Copy link
Member

@msimberg yes, you have understood perfectly. The hello world component builds with tests.unit.build.

@msimberg
Copy link
Contributor Author

I'm going to go ahead with this as we'll need this eventually. We can adjust it later on if needed.

@msimberg msimberg merged commit 7993867 into master Mar 27, 2018
@msimberg msimberg deleted the circle_2 branch March 27, 2018 19:10
@hkaiser hkaiser added this to the 1.2.0 milestone Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants