New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to CircleCI 2.0 #3036
Conversation
Thanks for pushing that! One thing we have to be aware of is that now, the circle checks will be flagged as failing, since we have lots of failing tests overall. But I think this is a good thing as it detects failures in PRs more easily and hopefully forces us to fix out tests. |
The other thing is, there will only be a new docker image once all tests pass ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections to merging this, thanks.
My remaining concern regarding this is that the header tests fail with "cannot allocate memory" and others. Should we disable them and try to get them running using pycicle or buildbot instead? We are not worse off disabling them as circleci 1 does not build them either now. |
@msimberg the existing CircleCI tests do run the header tests and I wouldn't like to lose that. |
@hkaiser Sorry, you're right. In that case that we should try to keep them running on circleci. |
Putting this for reference here: CircleCI 1.0 will not be supported anymore after August 31st, 2018. |
28f2eab
to
1493fa4
Compare
- Implemented parallel workflow instead of sequential tests. - Adding running of unit tests
c0e7cc9
to
5c14d76
Compare
I played around a bit more and changed the following:
|
Any remaining concerns over this one? @NK-Nikunj have I understood #3124 correctly that building the hello world component doesn't require any extra build steps now, and is part of tests/unit/build? I don't want to clobber your changes and end up with not building the hello world component again. The only thing which fails now is building the partitioned vector tests which will show up red until they're fixed, but that we can live with. |
@msimberg yes, you have understood perfectly. The hello world component builds with tests.unit.build. |
I'm going to go ahead with this as we'll need this eventually. We can adjust it later on if needed. |
As prepared by @sithhell. This should have very high priority in order to get tests running on PRs.