Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify util::tuple #838

Closed
K-ballo opened this issue Sep 8, 2013 · 2 comments
Closed

Simplify util::tuple #838

K-ballo opened this issue Sep 8, 2013 · 2 comments
Assignees
@K-ballo
Labels
category: core difficulty: medium type: enhancement
Milestone
0.9.7

Comments

@K-ballo
Copy link
Member

K-ballo commented Sep 8, 2013

Our implementation of tuple is overly complex. It should be simplified.
@ghost ghost assigned K-ballo Sep 8, 2013
K-ballo added a commit that referenced this issue Sep 9, 2013
@K-ballo
Simplify tuple.
f12a4a2 
See #838

Signed-off-by: K-ballo <k@fusionfenix.com>
@K-ballo
Copy link
Member Author

K-ballo commented Sep 10, 2013

Tomas Heller pointed out that the numbered tuples were helping reduce compilation time. We have to measure and see if there is a noticeable impact.

@K-ballo
Copy link
Member Author

K-ballo commented Sep 10, 2013

Tomas Heller reports no noticeable different with GCC 4.6:

Time it took without tupleN overloads:
real 4m7.254s
user 51m19.996s
sys 2m22.036s

Time it took with tupleN overloads:
real 4m8.285s
user 51m25.944s
sys 2m20.232s

@K-ballo K-ballo closed this as completed Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@K-ballo K-ballo

Labels
category: core difficulty: medium type: enhancement
Projects
None yet
Milestone
0.9.7
Development

No branches or pull requests
1 participant
@K-ballo