Fixing memory leak #1951
Merged
Fixing memory leak #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add parcelhandler::put_parcels - fixed parcelport_impl::put_parcels not to send parcels separately - add test for put_parcels - flyby change: improved argument handling in coalescing_message_handler
- fixing parcelport::put_parcels API - adding test
- adding a new API for discovering performance counters used in the tests
- clean up API - adding additional error checks - avoid calling into parcel-send operation if not necessary - fixing error message
|
LGTM, thanks! |
|
It's just strange that this PR includes half of #1942 |
|
Yup ... I should have cherry picked the commit instead of checking out ... stupid git ... let's merge #1942 first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.