Adding ability to statistics counters to reset base counter #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds an additional (optional) parameter to the statistics counter names allowing to specify whether the underlying counter should be reset during evaluation. - This also improves error reporting related to the parameters specified for statistics counters - this fixes #2743
|
@justwagle this addresses the issue you created (#2743), please verify. |
|
The added feature works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional (optional) parameter to the statistics counter names allowing
to specify whether the underlying counter should be reset during evaluation.
This also improves error reporting related to the parameters specified for statistics
counters
this fixes Statistics counter does not support reseting #2743