Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OS thread suspension #3046

Merged
merged 74 commits into from Dec 8, 2017
Merged

Add OS thread suspension #3046

merged 74 commits into from Dec 8, 2017

Commits on Nov 2, 2017

  1. Unrevert reverted throttle changes

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    aa681ca View commit details
    Browse the repository at this point in the history

  2. Fix selection of thread number in create_thread

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    14f0572 View commit details
    Browse the repository at this point in the history

  3. Make throttle test work with any (>= 2) number of threads

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    831f93b View commit details
    Browse the repository at this point in the history

  4. Remove auto variables

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    ecf95ee View commit details
    Browse the repository at this point in the history

  5. Correct test indexes

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    a5cabfa View commit details
    Browse the repository at this point in the history

  6. Correct small mistake in local_priority_queue_scheduler.hpp cleanup_t… 

    …erminated function
    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    2c25353 View commit details
    Browse the repository at this point in the history

  7. Fix thread selection in local_queue_scheduler.hpp

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    41df266 View commit details
    Browse the repository at this point in the history

  8. Clean up throttle test

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    0e73109 View commit details
    Browse the repository at this point in the history

  9. Remove thread_map_count_ check from cleanup_terminated

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    3b450a8 View commit details
    Browse the repository at this point in the history

  10. Try cleaning up terminated threads in all pools in threadmanager

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    7aa0b6e View commit details
    Browse the repository at this point in the history

  11. Add counter for background threads

    @msimberg
    msimberg committed Nov 2, 2017
    Copy the full SHA
    fd390e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2017

  1. Split up cleanup_terminated functions 

    One version takes the thread number and the other cleans up in all worker
threads.
    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    ef9fcb8 View commit details
    Browse the repository at this point in the history

  2. Ignore thread map counts in cleanup_threads functions

    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    a9ce6a1 View commit details
    Browse the repository at this point in the history

  3. Fix typo in shared_priority_scheduler.hpp

    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    b992a30 View commit details
    Browse the repository at this point in the history

  4. Correct thread number in add_processing_unit

    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    1973678 View commit details
    Browse the repository at this point in the history

  5. Use wrapper struct for background thread count

    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    1f316a6 View commit details
    Browse the repository at this point in the history

  6. Ensure thread status is running when add_processing_unit returns

    @msimberg
    msimberg committed Nov 7, 2017
    Copy the full SHA
    8d624e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2017

  1. Add HPX_EXPORT for background thread count functionality 

    Add HPX_EXPORT to hopefully fix msvc build errors.
    @msimberg
    msimberg committed Nov 9, 2017
    Copy the full SHA
    ddfb164 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. Add test to explicitly check removing pu on which thread is running

    @msimberg
    msimberg committed Nov 10, 2017
    Copy the full SHA
    8e6de2e View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary argc, argv from throttle test

    @msimberg
    msimberg committed Nov 10, 2017
    Copy the full SHA
    d0d7c88 View commit details
    Browse the repository at this point in the history

  3. Add test to check shutdown with removed pus

    @msimberg
    msimberg committed Nov 10, 2017
    Copy the full SHA
    092627f View commit details
    Browse the repository at this point in the history

  4. Fix inspect errors

    @msimberg
    msimberg committed Nov 10, 2017
    Copy the full SHA
    9ab1fd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Correct cleanup_terminated and wait_or_add_new behavior

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    745e4d8 View commit details
    Browse the repository at this point in the history

  2. Revert back to more strict scheduler loop termination criteria 

    Preparation for adding suspension which can be more relaxed.
    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    4390560 View commit details
    Browse the repository at this point in the history

  3. Add throttle test with timed tasks, don't exit throttle tests with re… 

    …moved pus
    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    581350d View commit details
    Browse the repository at this point in the history

  4. First version of suspending threads

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    6ab006b View commit details
    Browse the repository at this point in the history

  5. Change throttle tests to suspend/resume pus instead of remove/add

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    aa14453 View commit details
    Browse the repository at this point in the history

  6. Relax scheduling loop termination criteria when suspending pus

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    f667175 View commit details
    Browse the repository at this point in the history

  7. Clean up shutdown_suspended_pus test

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    b6b850c View commit details
    Browse the repository at this point in the history

  8. Temporarily disable tests in throttle test 

    Testing the wrong thing, the correct functions are not yet implemented.
    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    1991a86 View commit details
    Browse the repository at this point in the history

  9. Resume pools when shutting down

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    0dbb4b0 View commit details
    Browse the repository at this point in the history

  10. Fix checks for if remove_processing_unit etc. are called from within … 

    …runtime
    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    865c474 View commit details
    Browse the repository at this point in the history

  11. Do suspension tests with different schedulers

    @msimberg
    msimberg committed Nov 21, 2017
    Copy the full SHA
    001bc70 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Add function to get number of active pus on thread pool

    @msimberg
    msimberg committed Nov 22, 2017
    Copy the full SHA
    72cd972 View commit details
    Browse the repository at this point in the history

  2. Clean up resuming pools at shutdown

    @msimberg
    msimberg committed Nov 22, 2017
    Copy the full SHA
    688f0cd View commit details
    Browse the repository at this point in the history

  3. Simplify check for enabled pus in create_thread

    @msimberg
    msimberg committed Nov 22, 2017
    Copy the full SHA
    020665c View commit details
    Browse the repository at this point in the history

  4. Fix accidentally removed variable in scheduled_thread_pool_impl.hpp

    @msimberg
    msimberg committed Nov 22, 2017
    Copy the full SHA
    c9e368d View commit details
    Browse the repository at this point in the history

  5. Make scheduling loop wait for suspended tasks when suspending pu

    @msimberg
    msimberg committed Nov 22, 2017
    Copy the full SHA
    14a4d86 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2017

  1. Fix scheduling loop termination when stopping

    @msimberg
    msimberg committed Nov 23, 2017
    Copy the full SHA
    cd07d25 View commit details
    Browse the repository at this point in the history

  2. Fix pu selection again in local_priority_queue_scheduler

    @msimberg
    msimberg committed Nov 23, 2017
    Copy the full SHA
    0bf0d59 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2017

  1. Change background thread count to be scheduler specific

    @msimberg
    msimberg committed Nov 24, 2017
    Copy the full SHA
    010f636 View commit details
    Browse the repository at this point in the history

  2. Add new state for suspending schedulers to avoid conflict with existi… 

    …ng use
    @msimberg
    msimberg committed Nov 24, 2017
    Copy the full SHA
    235ddc2 View commit details
    Browse the repository at this point in the history

  3. Wait for work to finish in this_thread/thread_pool_executors before s… 

    …topping
    @msimberg
    msimberg committed Nov 24, 2017
    Copy the full SHA
    fc12976 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Clean up function to get active os thread count

    @msimberg
    msimberg committed Nov 27, 2017
    Copy the full SHA
    a53be0d View commit details
    Browse the repository at this point in the history

  2. Clean up background thread count in scheduling loop

    @msimberg
    msimberg committed Nov 27, 2017
    Copy the full SHA
    75e5241 View commit details
    Browse the repository at this point in the history

  3. Clean up scheduling loop termination/suspension

    @msimberg
    msimberg committed Nov 27, 2017
    Copy the full SHA
    c4addbd View commit details
    Browse the repository at this point in the history

  4. Rename state_going_to_sleep to state_pre_sleep

    @msimberg
    msimberg committed Nov 27, 2017
    Copy the full SHA
    619507b View commit details
    Browse the repository at this point in the history

  5. Clean up suspend/resume_processing_unit functions

    @msimberg
    msimberg committed Nov 27, 2017
    Copy the full SHA
    d3ee009 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2017

  1. Merge branch 'master' into suspend-thread

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    cd8f0c1 View commit details
    Browse the repository at this point in the history

  2. Clean up used_processing_units usage 

    Only use used_processing_units for setting service pool affinities. When deciding if pool threads are disabled use scheduler status instead, as used_processing_units is correct only with pu affinity and no oversubscription.
    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    afd673d View commit details
    Browse the repository at this point in the history

  3. Wake up suspended threads earlier during shutdown

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    c75978a View commit details
    Browse the repository at this point in the history

  4. Enable elasticity in suspension tests

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    4fba8e6 View commit details
    Browse the repository at this point in the history

  5. Enable more schedulers in suspension tests

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    0e52041 View commit details
    Browse the repository at this point in the history

  6. Correct check for active pus in throttle test

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    220b8b3 View commit details
    Browse the repository at this point in the history

  7. Set pool mode when setting scheduler mode

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    7b4ccbe View commit details
    Browse the repository at this point in the history

  8. Add checks for elasticity in resume/suspend_processing_unit

    @msimberg
    msimberg committed Nov 29, 2017
    Copy the full SHA
    634340d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2017

  1. Clean up todos in suspension tests

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    cc0c056 View commit details
    Browse the repository at this point in the history

  2. Clean up interface for resuming pool/thread manager from suspension

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    a56b932 View commit details
    Browse the repository at this point in the history

  3. Fix throttle hangup when resuming too early

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    7651ea2 View commit details
    Browse the repository at this point in the history

  4. Remove throttling_scheduler from throttle tests

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    0f98a51 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into suspend-thread

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    93bd23f View commit details
    Browse the repository at this point in the history

  6. Disable periodic priority queue scheduler in suspension tests

    @msimberg
    msimberg committed Nov 30, 2017
    Copy the full SHA
    8d50ead View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. Remove unnecessary include from threadmanager.cpp

    @msimberg
    msimberg committed Dec 1, 2017
    Copy the full SHA
    b50dd09 View commit details
    Browse the repository at this point in the history

  2. Fix alignment in scheduled_thread_pool_impl.hpp

    @msimberg
    msimberg committed Dec 1, 2017
    Copy the full SHA
    ca19a17 View commit details
    Browse the repository at this point in the history

  3. Tidy up thread_queue.hpp

    @msimberg
    msimberg committed Dec 1, 2017
    Copy the full SHA
    3a6490e View commit details
    Browse the repository at this point in the history

  4. Split up suspend/resume_processing units into internal and external

    @msimberg
    msimberg committed Dec 1, 2017
    Copy the full SHA
    a583da9 View commit details
    Browse the repository at this point in the history

  5. Add test for suspending without elasticity enabled

    @msimberg
    msimberg committed Dec 1, 2017
    Copy the full SHA
    9493840 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2017

  1. Add locks for adding/removing/suspending/resuming pus and scheduling … 

    …new work
    @msimberg
    msimberg committed Dec 4, 2017
    Copy the full SHA
    d06b49e View commit details
    Browse the repository at this point in the history

  2. Fix deadlock caused by too much locking while scheduling work

    @msimberg
    msimberg committed Dec 4, 2017
    Copy the full SHA
    d7f4ffb View commit details
    Browse the repository at this point in the history

  3. Fix indentation in scheduling loop

    @msimberg
    msimberg committed Dec 4, 2017
    Copy the full SHA
    0a07bff View commit details
    Browse the repository at this point in the history

  4. Relax exit criteria when stopping pu to be the same as for suspension

    @msimberg
    msimberg committed Dec 4, 2017
    Copy the full SHA
    df9409c View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. Merge branch 'master' into suspend-thread

    @msimberg
    msimberg committed Dec 5, 2017
    Copy the full SHA
    cee7d18 View commit details
    Browse the repository at this point in the history

  2. Clean up exit criteria again in scheduling loop

    @msimberg
    msimberg committed Dec 5, 2017
    Copy the full SHA
    39fe68d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Remove unnecessary mutexes in thread_pool_base

    @msimberg
    msimberg committed Dec 7, 2017
    Copy the full SHA
    903664d View commit details
    Browse the repository at this point in the history