Suspend thread pool #3110
Merged
Suspend thread pool #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlock during exceptional shutdown Previously stop_locked would block on calling resume_internal, even if blocking was set to false. This lead to deadlocks when multiple threads call stop_locked and assume that only one of them has blocking set to true.
Wrong function name passed to HPX_THROWS_IF
- Make sure there is an idle thread which can do the stealing - Add comments to warn about corner cases
Change state_suspended to state_sleeping.
I.e. don't use pending_boost to let other work run first.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
#3080 plus some.
There was a deadlock during an exceptional shutdown which this fixes by adding a non-blocking version of
resumetothread_pool_base.This also makes it clearer when it is possible to suspend the OS thread on which the suspending HPX thread is running.
Any background context you want to provide?
See #3080 and #3108.