Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve libCDS integration #4857

Merged
merged 6 commits into from Jul 25, 2020
Merged

Improve libCDS integration #4857

merged 6 commits into from Jul 25, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 24, 2020

  • make git repository and tag configurable
  • place generated projects in 'Core' FOLDER

@weilewei please check
@aurianer could we add this to the release, still (doesn't have to go into RC1)?

@hkaiser
Improve libCDS integration
91c2cd4 
- make git repository and tag configurable
- place generated projects in 'Core' FOLDER
@hkaiser hkaiser added this to the 1.5.0 milestone Jul 24, 2020
@weilewei weilewei self-requested a review July 24, 2020 17:00
weilewei
weilewei previously approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@weilewei weilewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@weilewei
Copy link
Contributor

weilewei commented Jul 24, 2020 •
edited

I modified the test a bit to directly use attach_thread interface provided by HP cds::gc::hp::smr::attach_thread();, this will not change the meaning of the test like before.

@hkaiser hkaiser merged commit 40397f2 into master Jul 25, 2020
@hkaiser hkaiser deleted the libcds_integration branch July 25, 2020 14:20
@aurianer
Copy link
Contributor

@hkaiser sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weilewei weilewei weilewei left review comments

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

@msimberg msimberg Awaiting requested review from msimberg

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hkaiser @weilewei @aurianer