Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust handling of CUDA/HIP options in CMake #5145

Merged
merged 2 commits into from Feb 8, 2021
Merged

Adjust handling of CUDA/HIP options in CMake #5145

merged 2 commits into from Feb 8, 2021

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Feb 4, 2021

Alternative to #5141. @biddisco could you check if the options behave the way you'd expect on this branch?

aurianer
aurianer previously approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@aurianer
Copy link
Contributor

aurianer commented Feb 5, 2021 •
edited

Side note: there is an open PR to add hip-lang as a CMake module, this would allow to use enable_language(HIP) as it's already possible with CUDA
EDIT: ROCm/HIP#2230

@msimberg
Copy link
Contributor Author

msimberg commented Feb 5, 2021

Side note: there is an open PR to add hip-lang as a CMake module, this would allow to use enable_language(HIP) as it's already possible with CUDA

Nice! Could you please link to that just for future reference?

Note I definitely missed a spot based on the CI results... I'll be pushing a fix for that soon.

@msimberg
Copy link
Contributor Author

msimberg commented Feb 8, 2021

@biddisco did you get a chance to try this out/does it look reasonable to you?

@msimberg msimberg mentioned this pull request Feb 8, 2021
Closed
@msimberg msimberg added this to the 1.6.0 milestone Feb 8, 2021
biddisco
biddisco requested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

cmake -DHPX_WITH_ASYNC_CUDA=ON -DHPX_WITH_CUDA_COMPUTE=OFF -DHPX_WITH_CUDA=OFF 

mak tests.unit.modules.async_cuda tests.performance.modules.async_cuda
ninja: error: unknown target 'tests.unit.modules.async_cuda'

@msimberg
Copy link
Contributor Author

msimberg commented Feb 8, 2021 

cmake -DHPX_WITH_ASYNC_CUDA=ON -DHPX_WITH_CUDA_COMPUTE=OFF -DHPX_WITH_CUDA=OFF 

mak tests.unit.modules.async_cuda tests.performance.modules.async_cuda
ninja: error: unknown target 'tests.unit.modules.async_cuda'

HPX_WITH_CUDA=OFF guards all CUDA functionality. You want cmake -DHPX_WITH_CUDA=ON -DHPX_WITH_CUDA_COMPUTE=OFF.

@msimberg msimberg merged commit 63a0c16 into STEllAR-GROUP:master Feb 8, 2021
@msimberg msimberg deleted the cuda-cmake-options branch February 8, 2021 15:16
@aurianer aurianer mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biddisco biddisco biddisco requested changes

@aurianer aurianer aurianer left review comments

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

Assignees
No one assigned
Labels
category: CMake platform: CUDA platform: HIP
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msimberg @aurianer @biddisco