Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atom/input): refactor #2310

Open
wants to merge 183 commits into
base: master
Choose a base branch
from
Open

Conversation

andresin87
Copy link
Member

@andresin87 andresin87 commented Sep 21, 2022

Atom/Input

❓ Ask

TASK:

Types of changes

  • πŸͺ² Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • πŸ“· Demo
  • πŸ§ͺ Test
  • 🧠 Refactor
  • πŸ’„ Styles

Description, Motivation and Context

The current AtomInput structure is giving problems with refs due to its HTML structure.

It also takes lots of improvements:

  • consistancy: mask and sui-password input types are able to work with icons and addons.
  • removes unnecesary wrappers.
  • avoid position absolutes.
  • removes an effortless giant mixin (performance)
  • updates imask

Screenshots - Animations

🚨🚨🚨🚨🚨🚨

This PR will remain iddle untill 1 person per vertical reviews its demo l&f and approves it at least.

Components which use @s-ui/react-atom-input or needs a review:

habitaclia milanuncios carfactory epreselect fotocasa motor infojobs Adevinta sui default
AtomInput ❌ βœ… βœ… βœ…
AtomTextArea βœ… βœ… βœ… βœ…
AtomTag βœ… βœ… βœ… βœ…
MoleculeAutosuggest βœ… βœ… βœ… βœ…
MoleculeAutosuggestField βœ… βœ… βœ… βœ…
MoleculeDataCounter βœ… βœ… βœ… βœ…
MoleculeDropdownList βœ… βœ… βœ… βœ…
MoleculeInputField βœ… βœ… βœ… βœ…
MoleculeInputTags βœ… βœ… βœ… βœ…
MoleculeSelect βœ… βœ… βœ… βœ…
All βœ… βœ… βœ… βœ…

Mark on each component when reviewing your branded components or just one mark at the end if everything is ok to confirm all the component changes:

  • βœ… if its ok
  • ❌ if it needs some fix

TEST on your vertical (if needed) installing:

  • @s-ui/react-molecule-autosuggest@2.65.0-beta.0
  • @s-ui/react-atom-input@5.21.0-beta.5
  • @s-ui/react-atom-tag@2.43.0-beta.2
  • @s-ui/react-molecule-input-tags@2.25.0-beta.0
  • @s-ui/react-molecule-select@1.55.0-beta.0

@@ -11,7 +11,7 @@
"dependencies": {
"@s-ui/react-hooks": "1",
"@s-ui/react-primitive-polymorphic-element": "1",
"imask": "3.4.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update a la react-imask: 6 con imask 6

@andresin87 andresin87 linked an issue Sep 23, 2022 that may be closed by this pull request
@SUI-Components SUI-Components deleted a comment from github-actions bot Sep 23, 2022
@SUI-Components SUI-Components deleted a comment from github-actions bot Sep 23, 2022
andresin87 and others added 26 commits October 14, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet