Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph-volume: fix stderr failure to decode/encode when redirected #333

Merged
merged 7 commits into from Sep 17, 2019
Merged

ceph-volume: fix stderr failure to decode/encode when redirected #333

merged 7 commits into from Sep 17, 2019

Conversation

smithfarm
Copy link

@smithfarm smithfarm commented Sep 17, 2019 •
edited

as requested by @jan--f

Fixes: SUSE/DeepSea#1747

Alfredo Deza added 7 commits September 17, 2019 11:25
@smithfarm
ceph-volume create a new tox.ini for shell-based tests
24c713c 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 4612ab3)
(cherry picked from commit 7c63650)
@smithfarm
ceph-volume create a logger for the terminal
a21d95d 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 95b16b5)
(cherry picked from commit bdf6a8b)
@smithfarm
ceph-volume: instantiate the new terminal logger in main()
a0f0f17 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit bfb8422)
(cherry picked from commit 26b97ec)
@smithfarm
ceph-volume terminal remove unicode stream handler
e75be27 
This caused problems in environments where stderr was redirected, since
stderr sets the encoding to None. Getting it back again allows
everything to work correctly, and keeps all the current unit tests
passing

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit fe66e01)
(cherry picked from commit d1615c0)
@smithfarm
ceph-volume tests verify new logging fallback and encodings in terminal
a571b68 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit ee18ebc)
(cherry picked from commit cd82ab7)
@smithfarm
ceph-volume tests create a shell test for functional unicode
e5cf3d0 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 595e492)
(cherry picked from commit 1c2894d)
@smithfarm
ceph-volume tests create a test file for checking unicode output
0fb803e 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 7919635)
(cherry picked from commit 4183d29)
@smithfarm smithfarm added this to the ses6 milestone Sep 17, 2019
jan--f
jan--f approved these changes Sep 17, 2019
View reviewed changes
Copy link

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks. Will test it asap.

@smithfarm smithfarm merged commit 4725967 into ses6-downstream-commits Sep 17, 2019
@smithfarm smithfarm deleted the wip-deepsea-1747 branch September 17, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

@LenzGr LenzGr Awaiting requested review from LenzGr

@jschmid1 jschmid1 Awaiting requested review from jschmid1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ses6
2 participants
@smithfarm @jan--f