Skip to content

Commit

Permalink
minipack: Add missing sensor name in pal.c (facebook#93)
Browse files Browse the repository at this point in the history
Summary:
1. Add missing sensor name in pal.c to fix repeated display problem.
Pull Request resolved: facebookexternal/openbmc.accton#93

Test Plan:
Test on minipack:pass

display log of sensor-util before modify:

PV_BAT_VOLT                    (0xD7) :    3.32 Volts | (ok)
PV_BAT_VOLT                    (0xD8) :    1.22 Volts | (ok)
P1V05_MIX_VOLT               (0x8E) :    1.04 Volts | (ok)
1V05MIX_VR_CURR          (0x84) :    2.12 Amps  | (ok)
VDDR_VR_CURR               (0x85) :    0.50 Amps  | (ok)
VCCIN_VR_CURR              (0x83) :    3.00 Amps  | (ok)
VCCIN_VR_VOLT                (0x88) :    1.80 Volts | (ok)
VCCIN_VR_VOLT                (0x8A) :    1.21 Volts | (ok)
VCCIN_VR_VOLT                (0x89) :    1.05 Volts | (ok)

display log of sensor-util after modify:

PV_BAT_VOLT                    (0xD7) :    3.32 Volts | (ok)
PVDDR_VOLT                     (0xD8) :    1.22 Volts | (ok)
P1V05_MIX_VOLT               (0x8E) :    1.04 Volts | (ok)
1V05MIX_VR_CURR          (0x84) :    1.88 Amps  | (ok)
VDDR_VR_CURR               (0x85) :    2.50 Amps  | (ok)
VCCIN_VR_CURR              (0x83) :    9.00 Amps  | (ok)
VCCIN_VR_VOLT                 (0x88) :    1.79 Volts | (ok)
VDDR_VR_VOL                   (0x8A) :    1.21 Volts | (ok)
1V05MIX_VR_VOL              (0x89) :    1.05 Volts | (ok)

Reviewed By: vineelasmile

fbshipit-source-id: fce919a93
  • Loading branch information
vineelasmile authored and facebook-github-bot committed Oct 10, 2018
1 parent 82e74ac commit 7b4f4f0
Showing 1 changed file with 19 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3687,6 +3687,9 @@ get_scm_sensor_name(uint8_t sensor_num, char *name) {
case BIC_SENSOR_PV_BAT:
sprintf(name, "PV_BAT_VOLT");
break;
case BIC_SENSOR_PVDDR:
sprintf(name, "PVDDR_VOLT");
break;
case BIC_SENSOR_P1V05_MIX:
sprintf(name, "P1V05_MIX_VOLT");
break;
Expand All @@ -3702,8 +3705,14 @@ get_scm_sensor_name(uint8_t sensor_num, char *name) {
case BIC_SENSOR_VCCIN_VR_VOL:
sprintf(name, "VCCIN_VR_VOLT");
break;
case BIC_SENSOR_VDDR_VR_VOL:
sprintf(name, "VDDR_VR_VOLT");
break;
case BIC_SENSOR_P1V05MIX_VR_VOL:
sprintf(name, "1V05MIX_VR_VOLT");
break;
case BIC_SENSOR_P1V05MIX_VR_POUT:
sprintf(name, "BP1V05MIX_VR_OUT_POWER");
sprintf(name, "1V05MIX_VR_OUT_POWER");
break;
case BIC_SENSOR_INA230_POWER:
sprintf(name, "INA230_POWER");
Expand Down Expand Up @@ -4679,8 +4688,11 @@ get_scm_sensor_units(uint8_t sensor_num, char *units) {
case BIC_SENSOR_P3V3_STBY_MB:
case BIC_SENSOR_P5V_STBY_MB:
case BIC_SENSOR_PV_BAT:
case BIC_SENSOR_PVDDR:
case BIC_SENSOR_P1V05_MIX:
case BIC_SENSOR_VCCIN_VR_VOL:
case BIC_SENSOR_VDDR_VR_VOL:
case BIC_SENSOR_P1V05MIX_VR_VOL:
case BIC_SENSOR_INA230_VOL:
sprintf(units, "Volts");
break;
Expand Down Expand Up @@ -5418,7 +5430,10 @@ pal_sensor_assert_handle(uint8_t fru, uint8_t snr_num,
case BIC_SENSOR_P1V05_PCH:
case BIC_SENSOR_P3V3_STBY_MB:
case BIC_SENSOR_PV_BAT:
case BIC_SENSOR_PVDDR:
case BIC_SENSOR_VCCIN_VR_VOL:
case BIC_SENSOR_VDDR_VR_VOL:
case BIC_SENSOR_P1V05MIX_VR_VOL:
case BIC_SENSOR_INA230_VOL:
snr_desc = get_sensor_desc(fru, snr_num);
sprintf(crisel, "%s %s %.2fV - ASSERT,FRU:%u",
Expand Down Expand Up @@ -5474,7 +5489,10 @@ pal_sensor_deassert_handle(uint8_t fru, uint8_t snr_num,
case BIC_SENSOR_P1V05_PCH:
case BIC_SENSOR_P3V3_STBY_MB:
case BIC_SENSOR_PV_BAT:
case BIC_SENSOR_PVDDR:
case BIC_SENSOR_VCCIN_VR_VOL:
case BIC_SENSOR_VDDR_VR_VOL:
case BIC_SENSOR_P1V05MIX_VR_VOL:
case BIC_SENSOR_INA230_VOL:
snr_desc = get_sensor_desc(FRU_SCM, snr_num);
sprintf(crisel, "%s %s %.2fV - DEASSERT,FRU:%u",
Expand Down

0 comments on commit 7b4f4f0

Please sign in to comment.