feat: add discrete saving functionality #1019
Draft
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
1b090e7
to
4826b3c
Compare
| @@ -611,6 +613,9 @@ end | |||
| end | |||
| integrator.u_modified = true | |||
| callback.affect!(integrator) | |||
|
|
|||
| SciMLBase.save_discrete_parameters_after_callback( | |||
| integrator.sol, parameter_values(integrator), current_time(integrator)) | |||
There was a problem hiding this comment.
so it would interpolate separately?
There was a problem hiding this comment.
Interpolation is independent of this. I haven't gotten around to it yet
There was a problem hiding this comment.
Interpolation is implemented in SciML/SciMLBase.jl#645
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
4826b3c
to
dd8a670
Compare
5 tasks
|
Requires SciML/SciMLBase.jl#645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.