dualT4 should not be promoted with T since T might already be a dual
#958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/SciML/DiffEqBase.jl/actions/runs/6749257536/job/18349252125?pr=958 this failure looks very real. |
oscardssmith
force-pushed
the
fix-wrapfun_iip
branch
from
479045e
to
f4eb1af
Compare
|
CI is required to confirm, but I think this might finally work. The problem we were running into previously is that |
|
https://github.com/SciML/DiffEqBase.jl/actions/runs/6852222169/job/18630260564?pr=958#step:6:1416 that's a real test failure. |
|
yeah this pr I believe only works once my ordinarydiffeq pr is merged |
oscardssmith
force-pushed
the
fix-wrapfun_iip
branch
from
7319441
to
5473ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the second part of the fix for SciML/DifferentialEquations.jl#994