Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steady state default algorithm test #1019

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

thomvet
Copy link
Contributor

@thomvet thomvet commented Feb 27, 2024

Test was failing. This is probably a ripple effect of changes in NonlinearSolve.jl, DifferentialEquations.NonlinearSolve.NewtonRaphson now points to a function (not a type anymore).

The change introduced compares the algorithm name instead of the type (using NonlinearSolve.get_name). The other way of fixing it would of course be to have the NonlinearSolve.NewtonRaphson also be a type instead of just a function (as it previously was).

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (6d05a21) to head (7eaf874).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   86.09%   85.43%   -0.67%     
==========================================
  Files          11       11              
  Lines         151      151              
==========================================
- Hits          130      129       -1     
- Misses         21       22       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit f6b1366 into SciML:master Mar 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants