Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ODE algorithms: Use FBDF for problems with > 50 states #1024

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

devmotion
Copy link
Member

There are two identical conditions length(prob.u0) > 500 in a single if - elseif - ... statement, so the second one is never hit. Based on the branches for problems with :auto hints below and the logic prior to #977, I assume that the second condition was introduced accidentally in #977 and was supposed to be length(prob.u0) > 50.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (8ce23d2) to head (b097bfd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          11       11           
  Lines         151      151           
=======================================
  Hits          129      129           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 69210d2 into master Apr 3, 2024
5 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dw/fix_ode_mm_defaults branch April 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants