Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test warnings #411

Merged
merged 3 commits into from Mar 26, 2024
Merged

Fix test warnings #411

merged 3 commits into from Mar 26, 2024

Conversation

isaacsas
Copy link
Member

This fixes most warnings that arise in tests in the hopes of maybe fixing the CI issue in #410.

Should not be merged until after #409

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8441700646

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 86.015%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/problem.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 8422543521: -0.005%
Covered Lines: 2208
Relevant Lines: 2567

💛 - Coveralls

@isaacsas
Copy link
Member Author

It appears fixing those warnings fixes the CI issues on Github, so after tests pass will merge and then make the new release.

@isaacsas isaacsas merged commit afab13e into SciML:master Mar 26, 2024
6 of 7 checks passed
@isaacsas isaacsas deleted the fix_test_warnings branch March 26, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants