Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upsample to instantaneous #171

Merged
merged 3 commits into from Mar 18, 2024
Merged

Conversation

Flix6x
Copy link
Collaborator

@Flix6x Flix6x commented Mar 12, 2024

No description provided.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the Resampling Dealing with downsampling and/or upsampling label Mar 12, 2024
@Flix6x Flix6x self-assigned this Mar 12, 2024
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

timely_beliefs/beliefs/utils.py Show resolved Hide resolved
timely_beliefs/tests/test_df_resampling.py Outdated Show resolved Hide resolved
timely_beliefs/beliefs/utils.py Show resolved Hide resolved
timely_beliefs/tests/test_df_resampling.py Show resolved Hide resolved
@Flix6x
Copy link
Collaborator Author

Flix6x commented Mar 15, 2024

Thanks. Did we clear things up?

By the way, one of my longstanding dreams is to support sensors with dynamic resolution, where the events have to define their own resolution (which becomes another index in the BeliefsDataFrame). That's basically the way that time series can be defined in FlexMeasures' flex-model fields (for SoC constraints).

(Todo: I still want to amend the docstring to mention the frequency is 1 hour.)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@victorgarcia98
Copy link
Contributor

Thanks. Did we clear things up?

By the way, one of my longstanding dreams is to support sensors with dynamic resolution, where the events have to define their own resolution (which becomes another index in the BeliefsDataFrame). That's basically the way that time series can be defined in FlexMeasures' flex-model fields (for SoC constraints).

(Todo: I still want to amend the docstring to mention the frequency is 1 hour.)

The discussion helped, thanks!

Now it's clear for me. Before I thought that the scheduler assumed that the SOC to be at the end of the periods, instead of the start.

@Flix6x Flix6x merged commit 4e6a6f5 into main Mar 18, 2024
5 checks passed
@Flix6x Flix6x deleted the feature/upsample-to-instantaneous branch March 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resampling Dealing with downsampling and/or upsampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants