Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop dayfirst attribute before read_excel. #173

Merged
merged 1 commit into from Mar 21, 2024

Conversation

victorgarcia98
Copy link
Contributor

Pandas read_csv function was complaining because we were providing an unexpected keyword argument dayfirst and I moved the already existing pop call before the function call.

So far, I can't explain why it worked before. Maybe it has to do with the function signature being updated with in a more recent version which doesn't allow for extra arguments.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 added the bug Something isn't working label Mar 21, 2024
@victorgarcia98 victorgarcia98 self-assigned this Mar 21, 2024
Copy link
Collaborator

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had introduced this bug in #170.

@Flix6x Flix6x merged commit f166edf into main Mar 21, 2024
1 of 2 checks passed
@Flix6x Flix6x deleted the fix/pop-day-first-before-reading-excel branch March 21, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants