Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button to copy seed #68

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added button to copy seed #68

wants to merge 8 commits into from

Conversation

Mina928
Copy link

@Mina928 Mina928 commented Oct 29, 2023

This PR works on implementing one of the features in issue #62

This issue suggests methods to save and copy seeds, to make it easier for player to replay the same version of the game again. This PR added a new button next to the random seed button, which upon being clicked saves the seed to the user's clipboard, allowing them to easily paste it somewhere else for future use.

The new button needed different sprites, so two new sprites were created, then packaged using the GDX Texture Packer. The newly packages files replaced the old ones. Currently the random seed button and copy seed button have the same sprites, as trying to get unique sprites was leading to issues.

@Sesu8642
Copy link
Owner

I managed to fix the buttons having the same image and iterated on the icons a bit. I think it now works as you intended. 😃

There are two changes I would like to have before merging. Let me know whether you want to work more on that or I should do it.

  1. User feedback. Displaying the tick is a good idea but on touch devices it cannot really be seen cause the finger is on the button. I think the pressed button should have a "pressed" version of the copy icon. One idea to give better feedback would be to change the icon to the tick icon for maybe one second after the button was released and then change it back to the copy icon. This would give users a better chance to see the tick. But it's also a bit annoying to implement. Maybe you have better ideas.
  2. The width of the other inputs above the seed row should be increased to match the new seed row width.

@Mina928
Copy link
Author

Mina928 commented Oct 30, 2023

Wow nice thanks for the help. Yes these are good suggestions, I can start looking into making those changes.

@Mina928
Copy link
Author

Mina928 commented Nov 19, 2023

Hey so sorry for the lack responsiveness recently. I have gotten very busy and am not sure when I will have time to work on this again. Thanks so much for the experience and assistance, it was fun. Wish you luck!

@Sesu8642
Copy link
Owner

No worries. I will finish this. Thanks for your help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants