Skip to content

Commit

Permalink
[377] Prevent achievements/statistics comparison for non-existent cha…
Browse files Browse the repository at this point in the history
…racters
  • Loading branch information
Ashen authored and Shadez committed Aug 27, 2010
1 parent bd7b996 commit 5fe2d09
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README
Expand Up @@ -22,5 +22,5 @@

WARNING: You must not remove and/or change any Blizzard's copyrights in any files and/or at the bottom of Armory pages!

World of Warcraft, Blizzard Entertainment are trademarks or registered trademarks of Blizzard Entertainment, Inc. in the U.S. and/or other countries.
World of Warcraft, Blizzard Entertainment are trademarks or registered trademarks of Blizzard Entertainment, Inc. in the U.S. and/or other countries.
The data contained herein is proprietary to Blizzard Entertainment, Inc. You are granted a limited license to make personal use of the information contained herein for non-commercial purposes only.
9 changes: 7 additions & 2 deletions character-achievements.php
Expand Up @@ -3,7 +3,7 @@
/**
* @package World of Warcraft Armory
* @version Release Candidate 1
* @revision 369
* @revision 377
* @copyright (c) 2009-2010 Shadez
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
Expand Down Expand Up @@ -63,7 +63,12 @@
foreach($comparisonData as $char) {
$comparison[$i] = new Characters;
$comparison[$i]->BuildCharacter($char['name'], $utils->GetRealmIdByName($char['realm']), true);
$i++;
if(!$comparison[$i]->CheckPlayer()) {
array_pop($comparison);
}
else {
$i++;
}
}
//
$name = $comparisonData[0]['name'];
Expand Down
9 changes: 7 additions & 2 deletions character-statistics.php
Expand Up @@ -3,7 +3,7 @@
/**
* @package World of Warcraft Armory
* @version Release Candidate 1
* @revision 370
* @revision 377
* @copyright (c) 2009-2010 Shadez
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
Expand Down Expand Up @@ -60,7 +60,12 @@
foreach($comparisonData as $char) {
$comparison[$i] = new Characters;
$comparison[$i]->BuildCharacter($char['name'], $utils->GetRealmIdByName($char['realm']), true);
$i++;
if(!$comparison[$i]->CheckPlayer()) {
array_pop($comparison);
}
else {
$i++;
}
}
//
$name = $comparisonData[0]['name'];
Expand Down
2 changes: 1 addition & 1 deletion includes/revision_nr.php
@@ -1,5 +1,5 @@
<?php
define('ARMORY_REVISION', 376);
define('ARMORY_REVISION', 377);
define('DB_VERSION', 'armory_r361');
define('CONFIG_VERSION', '0708201001');
?>

0 comments on commit 5fe2d09

Please sign in to comment.