Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs and example for tile #1994

Merged
merged 1 commit into from
May 22, 2024
Merged

Added docs and example for tile #1994

merged 1 commit into from
May 22, 2024

Conversation

js-goupil
Copy link
Contributor

@js-goupil js-goupil commented May 21, 2024

Resolves https://github.com/Shopify/pos-next-react-native/issues/36278

Background

Adds some documentation and code examples for the Tile component.

Solution

Skipping the asset for now, since we're going to be adding fresh ones later.

馃帺

https://shopify-dev.ui-extensions-7t4u.jeansebastien-goupil.us.spin.dev/docs/api/pos-ui-extensions/unstable/components/tile

Checklist

  • I have 馃帺'd these changes
  • I have updated relevant documentation

@js-goupil js-goupil requested a review from vctrchu May 21, 2024 17:21
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@vctrchu
Copy link
Contributor

vctrchu commented May 21, 2024

No references to images in your code so I'm assuming your spin instance is out of date which is why its showing the text area image still

Copy link
Contributor

@vctrchu vctrchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@js-goupil js-goupil merged commit fd54dd6 into unstable May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants