Add Test Coverage for SatisfiedPolicy and enhance SpendPolicy tests #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing more tests! I'll give this a proper review in the morning, but from a first pass it looks fine. |
lukechampine
requested changes
Mar 26, 2024
new0nebit
force-pushed
the
flourish
branch
4 times, most recently
from
ab2af1c
to
b038144
Compare
lukechampine
approved these changes
Apr 16, 2024
new0nebit
pushed a commit
to new0nebit/core
that referenced
this pull request
Apr 20, 2024
Add Test Coverage for SatisfiedPolicy and enhance SpendPolicy tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started writing this code during the last hackathon for fun, practicing writing test cases. But I didn't finish it because I had to switch to the main task regarding consensus coverage. I felt bad for wipe out a work that had been done, so I ended up finishing the code and also making some changes to it. Initially, I was only aiming to cover the
SatisfiedPolicybut got carried away and started covering thePolicyTypeAboveandPolicyTypePublicKey, completely overlooking the fact that you had already done this 😅 Anyway, here it is. I hope that this alternative approach and the additional scenarios will prove valuable to you 🙏