Add context to syncer.Connect #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/syncer-context
branch
from
5928617
to
84423ee
Compare
n8maninger
reviewed
Mar 6, 2024
ChrisSchinnerl
requested changes
Mar 7, 2024
ChrisSchinnerl
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some TODOs in
renterdfor missing contexts in some of the newcoreutils, but after closer inspection I can see why no contexts were added. Not sure if I totally agree in all cases though, for instance the chain manager never takes a context, even though the store is injected and might be a remote database or something so I think there's something to say for extending theStore interfaceand add a context to literally every method... That said, I thinksyncer.Connectis the only one that's really missing a context so I decided to suggest adding it.