Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miner logic #69

Merged
merged 4 commits into from Apr 2, 2024
Merged

Fix miner logic #69

merged 4 commits into from Apr 2, 2024

Conversation

n8maninger
Copy link
Member

No description provided.

lukechampine
lukechampine reviewed Mar 11, 2024
View reviewed changes
cmd/walletd/miner.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that the whole method was moved + the lack of PR description makes it quite hard to figure out what the logic is that required fixing ^^

cmd/walletd/miner.go Outdated Show resolved Hide resolved
cmd/walletd/miner.go Outdated Show resolved Hide resolved
@n8maninger
Copy link
Member Author

The fact that the whole method was moved + the lack of PR description makes it quite hard to figure out what the logic is that required fixing ^^

Don't worry about it 😛

@lukechampine lukechampine merged commit ec95962 into master Apr 2, 2024
8 checks passed
@lukechampine lukechampine deleted the nate/fix-miner-logic branch April 2, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechampine lukechampine lukechampine approved these changes

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl

Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n8maninger @lukechampine @ChrisSchinnerl