Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retain the query name,expression and disabled property on changing panel type #4976

Merged
merged 2 commits into from May 20, 2024
Merged

fix: retain the query name,expression and disabled property on changing panel type #4976

merged 2 commits into from May 20, 2024
+49 −0

Conversation

Vikrant2520
Copy link
Collaborator

@Vikrant2520 Vikrant2520 commented May 10, 2024 •
edited

Summary

  • the query name was not getting retained on switching the panel type causing functions to fail
  • the disabled state of the queries was not getting translated on changing panel type.
  • added the missing sync for superset query for reset and init query builder data

Related Issues / PR's

fixes - #4974

Screenshots

Screen.Recording.2024-05-10.at.1.00.57.PM.mov

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label May 10, 2024
@Vikrant2520 Vikrant2520 changed the title fix: retain the query name,expression and disabled property on changi… fix: retain the query name,expression and disabled property on changing panel type May 10, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@Vikrant2520 Vikrant2520 marked this pull request as ready for review May 10, 2024 07:38
@Vikrant2520 Vikrant2520 requested a review from YounixM as a code owner May 10, 2024 07:38
@Vikrant2520 Vikrant2520 force-pushed the panel-type-naming-issue branch 2 times, most recently from 072bc6d to 3cf84aa Compare May 12, 2024 11:56
@Vikrant2520 Vikrant2520 merged commit 2dbe598 into develop May 20, 2024
11 of 12 checks passed
@Vikrant2520 Vikrant2520 deleted the panel-type-naming-issue branch May 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vikrant2520 @YounixM @SagarRajput-7