Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean(autogpt): Remove old plugin system #7097

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Apr 22, 2024

Background

Follow up after merging #7054, old plugins will no longer be used.

Changes 🏗️

  • Removed all dead code needed to load and use plugins.
  • Removed auto-gpt-plugin-template dependency
  • Removed rev= from autogpt-forge dependency (the set rev had incompatible duckduckgo-search versions)
  • Kept --install-plugin-deps CLI option and dead code associated (may be needed for new plugins)

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 9e539a7
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/662e9d41a62c6c0008667af5
😎 Deploy Preview https://deploy-preview-7097--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 22, 2024
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@kcze
Copy link
Contributor Author

kcze commented Apr 23, 2024

Do we want to keep --install-plugin-deps CLI option, assuming we want automatic deps install for new plugins? Can we make it a bool in config/env?

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 23, 2024
Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.87%. Comparing base (0014e2a) to head (9e539a7).

Files Patch % Lines
autogpts/autogpt/autogpt/app/main.py 50.00% 1 Missing ⚠️
autogpts/autogpt/autogpt/app/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7097      +/-   ##
==========================================
- Coverage   45.35%   43.87%   -1.49%     
==========================================
  Files         133      129       -4     
  Lines        6438     6065     -373     
  Branches      859      783      -76     
==========================================
- Hits         2920     2661     -259     
+ Misses       3396     3300      -96     
+ Partials      122      104      -18     
Flag Coverage Δ
Linux 43.79% <66.66%> (-1.49%) ⬇️
Windows 41.87% <66.66%> (-1.61%) ⬇️
autogpt-agent 43.84% <66.66%> (-1.49%) ⬇️
macOS 43.14% <66.66%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kcze kcze marked this pull request as ready for review April 23, 2024 11:04
@kcze kcze requested a review from a team as a code owner April 23, 2024 11:04
@Swiftyos
Copy link
Contributor

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Review

⏱️ Estimated effort to review [1-5]

3, because the PR involves a significant amount of deletions across multiple files, which requires careful review to ensure that no essential functionality is accidentally removed or broken. The removal of plugin-related code impacts various components, necessitating a thorough check to ensure that all dependencies and references are correctly handled.

🧪 Relevant tests

No

🔍 Possible issues

Possible Bug: The PR retains the --install-plugin-deps CLI option and associated dead code, which might lead to confusion or errors if the functionality is partially removed but still accessible.

🔒 Security concerns

No

Code feedback:
relevant fileautogpts/autogpt/autogpt/app/main.py
suggestion      

Consider removing or refactoring the --install-plugin-deps CLI option since the related plugin functionality is being removed. This will prevent potential confusion or errors from users trying to use a partially supported feature. [important]

relevant linefrom autogpt.logs.config import configure_logging

relevant fileautogpts/autogpt/autogpt/agent_factory/configurators.py
suggestion      

Ensure that all references to plugin-related functionality are removed from documentation and help text throughout the application to maintain consistency and avoid user confusion. [important]

relevant line- configure_chat_plugins(app_config)

relevant fileautogpts/autogpt/autogpt/logs/config.py
suggestion      

Verify that no external modules or systems depend on the removed plugin logging functionalities, or provide alternative solutions if necessary. This ensures that all system integrations remain functional. [important]

relevant line-from auto_gpt_plugin_template import AutoGPTPluginTemplate

relevant fileautogpts/autogpt/autogpt/config/config.py
suggestion      

Since the plugin system is removed, consider cleaning up environment variables and configuration related to plugins that are no longer needed to simplify the configuration process and avoid unused clutter. [important]

relevant line-from auto_gpt_plugin_template import AutoGPTPluginTemplate


✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

  • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

ntindle
ntindle previously approved these changes Apr 28, 2024
autogpts/autogpt/.env.template Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 28, 2024
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2024
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2024
Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@kcze kcze changed the title clean(agent): Remove old plugin system clean(autogpt): Remove old plugin system Apr 28, 2024
@kcze kcze merged commit d38e8b8 into Significant-Gravitas:master Apr 28, 2024
17 of 19 checks passed
@kcze kcze deleted the kpczerwinski/open-657-remove-old-plugin-system branch April 28, 2024 19:19
kcze added a commit that referenced this pull request Apr 29, 2024
Revert line in `poetry.lock` to from before #7097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoGPT Agent documentation Improvements or additions to documentation size/xl
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants