Improve reliability of readyState on IE (possible fix for #154, #195) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt on fixing an unusual issue reported in details here - http://stackoverflow.com/questions/19781753/modernizr-load-callback-executing-before-loaded-script
The issue was very hard to isolate and reproduce, but I believe the following is true on IE8 and IE9:
When a script node is appended to the DOM and is not fully loaded, it will execute after loading, not necessarilly before the callback. When a fully loaded script is appended to the DOM, it is parsed and executed immediately, securely before the callback.
The changes on this commit resolved my problems on IE8 and IE9, and didn't cause any issue as far as I could see on latest (11/11/2013) Chrome, Firefox and Opera.