Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add option to disable python wrapping on loadable modules #6895

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RafaelPalomar
Copy link
Contributor

This makes the python wrapping for loadable module components depend on the Slicer_USE_PYTHONQT CMake variable. This avoids python wrapping when Slicer_USE_PYTHONQT=OFF, which can save generation of files that won't be used.

NOTE: For discussion purposes, so far, this PR applies the concept only to the MRML components of the Colors module, but the idea would be to apply this across modules and components. Alternatively, the Slicer_USE_PYTHONQT variable could be checked on the CMake SlicerBuild macros.

@pieper, @jcfr would these changes make sense to you?

This makes the python wrapping for loadable module components depend on
the `Slicer_USE_PYTHONQT` CMake variable
@RafaelPalomar RafaelPalomar marked this pull request as draft March 15, 2023 09:32
@jcfr
Copy link
Member

jcfr commented Mar 15, 2023

Generally speaking, fixing this makes sense.

Instead of adding code in each module (and extension), I suggest to instead update the Slicer CMake macros to skip wrapping if the option Slicer_USE_PYTHONQT is set to OFF.

@RafaelPalomar
Copy link
Contributor Author

Instead of adding code in each module (and extension), I suggest to instead update the Slicer CMake macros to skip wrapping if the option Slicer_USE_PYTHONQT is set to OFF.

That makes sense. I can work on it.

RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 26, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Apr 13, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 18, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 20, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 21, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 23, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Jun 23, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 25, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 27, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 28, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 29, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 30, 2023
This introduces `Slicer_USE_PYTHONQT` as a variable to consider for
python wrapping in `Base` and `Libs` components. This should probably be
merged with the developments on Slicer#6895 and with the
modernization of the python detection in earlier Systole patches
@jcfr jcfr added the Status: Draft This pull-request is not yet ready for integration label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Draft This pull-request is not yet ready for integration
Development

Successfully merging this pull request may close these issues.

None yet

2 participants