Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Virtual DHCP Server: Correct IP reassignment #1994

Merged
merged 3 commits into from
May 27, 2024

Conversation

hiura2023
Copy link
Contributor

@hiura2023 hiura2023 commented May 8, 2024

Changes proposed in this pull request:

  • DHCP_NAK does not work correctlly

  • Changes make it work correctlly

  • Description of changes:
    ①If IP address in user's note is changed, then reply to DHCP REQUEST with DHCP NAK.
    This makes DHCP sequence begin with DHCP DISCOVER.
    ②If there is any entry with the same MAC address, then remove it.
    Unused lease time record is deleted from IP lease table.
    ③Reassigning static IP address is partially modified.
    ④Thease changes enable to switch between static and dynamic IP address assignment.
    Users do not need to restart the VPN server.

  • Example below:
    Already set to IPv4:192.168.30.222 in user's note.
    First, set to IPv4:192.168.30.234 in user's note. Indicated with yellow line.
    Second, delete IPv4:192.168.30.234 from user's note. Indicated with yellow line.
    Third, set to IPv4:192.168.30.222 in user's note. Indicated with yellow line.
    User can switch the way of IP address assignment at any time.

  • Attach A:

Lease Limit:40 seconds
DisableSessionReconnect: true
Time-out Period: 20 seconds
dhcpfix_switch_static_dynamic2024-05-10

@chipitsine
Copy link
Member

this looks like a followup of #1947

@PizzaProgram , can you please test it ?

@chipitsine
Copy link
Member

@hiura2023 thank you very much for taking care of OpenSSL-3 issue.

I'm going to merge this PR (I would avoid nitpicking that it should be better to go into 2 separate PRs, anyway, there'll be separate commits, I am fine with that)

@chipitsine chipitsine merged commit bfaff4f into SoftEtherVPN:master May 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants