Multiple plates #5077
Multiple plates #5077
Conversation
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
|
you are on a roll with these QOL updates! thank you ❤️ |
|
I do have some help from a resource that's a quite a bit more skilled at C++ and OpenGL stuff than I am, but I'm learning. |
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
jamincollins
force-pushed
the
multiple-plates
branch
from
d2f3c9b
to
64319ec
Compare
|
Updated the comments (with help) to reflect the change. |
| // with int64_t we don't have to worry anymore about the size of the int. | ||
| static constexpr double SCALING_FACTOR = 0.000001; | ||
| static constexpr double SCALING_FACTOR = 0.00001; |
There was a problem hiding this comment.
Decreasing the precision here is not preferable.
I have plan to support large coords, it's not prioritized atm.
There was a problem hiding this comment.
I'll see about reworking this to disable the button before the issue presents itself.
There was a problem hiding this comment.
I'll see about reworking this to disable the button before the issue presents itself.
If this is in relation to the "add plate" button, note that disabling the button won't be a complete solution... because changing the printer type, or changing the size of the build plate for the current printer, can also cause this fault even without changing the number of plates...
|
@jamincollins |
Description
Fixes issue with attempting to create a large number of plates for a sizable bed (~400mm).
Corrects an enum update error
Screenshots/Recordings/Graphs
Without changes:
17x 400mm plates
With changes:
36x 400mm plates
Tests
Built and tested on Arch Linux.