Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys #5205

Closed
wants to merge 6 commits into from
Closed

Hotkeys #5205

wants to merge 6 commits into from

Conversation

jamincollins
Copy link
Contributor

Description

  • Fixes how the hotkey dialog is displayed
  • Sets the advertised (file menu) CTRL+Q hotkey for Linux and Windows

Screenshots/Recordings/Graphs

Before:
image
image

After:
image
image

Tests

Built and tested on Arch Linux.

Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
@yw4z
Copy link
Contributor

yw4z commented Apr 30, 2024

commited your branch my additions jamincollins#7
Optionally i disabled bold font for selected tab on my branch but didn't included this commit
if you ok with this changes, updated colors for tabs on my branch

Screenshot-20240430132354

@SoftFever
Copy link
Owner

SoftFever commented May 2, 2024

The cause looks like a font issue on Linux to me.
I'm not fully convinced that setting control's min size is a proper fix.

Also this cause a few issues on Windows
See the unnecessary scrollbar and tab color
image

@yw4z
Copy link
Contributor

yw4z commented May 2, 2024

@SoftFever i guess it was my mistake
sel->m_tab_text->SetBackgroundColour(StateColor::darkModeColorFor(wxColour("#F8F8F8")));
this lines should match with tab background

@jamincollins sent new commit for it jamincollins#9

yw4z and others added 2 commits May 2, 2024 19:02
@yw4z
Copy link
Contributor

yw4z commented May 2, 2024

@jamincollins perhaps problem is caused by bold font, frame calculated from normal font but text overflows when bold font used
ofc there is an another problem for normal font

@jamincollins
Copy link
Contributor Author

@jamincollins perhaps problem is caused by bold font, frame calculated from normal font but text overflows when bold font used

The problem was much more simple than that, they didn't really calculate the sizes:
3d7846d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants