Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flying Bear 2 fixes & fix Flying Bear name #5240

Closed
wants to merge 6 commits into from

Conversation

cochcoder
Copy link
Contributor

Fixes #4866

This PR renames FlyingBear to Flying Bear, renames Reborn 3 to Reborn 2, changes the Reborn 2 cover, and fixes Reborn 2's bed size. However, this PR will most likely break any custom profiles that were based on the old profiles due to some of the fixes.

@cochcoder cochcoder marked this pull request as draft May 3, 2024 00:21
@cochcoder
Copy link
Contributor Author

@SoftFever Please let me know if you're fine with the breaking changes or if you don't want to do those.

@Nathan22211
Copy link

flying bear does have a reborn 3 on their store, this doesn't do much,

@cochcoder
Copy link
Contributor Author

flying bear does have a reborn 3 on their store, this doesn't do much,

@ilko-k said this isn't the case in this comment.

@ilko-k
Copy link

ilko-k commented May 9, 2024

There was a Reborn 3 for a short of time, and Orca's "Reborn3" preset was available (with wrong picture and name) before the official release of that printer so it made sense to me that it was a mistake when compared to the actual Reborn 2. I don't know why the R3 is no more sold and it's also weird they removed any information about it (there still were units in stock), could be because of some defects reported by users.

@SoftFever
Copy link
Owner

@SoftFever Please let me know if you're fine with the breaking changes or if you don't want to do those.

Sorry for the late response.

Based on your and @ilko-k's discussion, would it make more sense to add the Bear 2 as a new model without deleting or touching the Bear 3 model?

@ilko-k
Copy link

ilko-k commented May 9, 2024

@SoftFever Please let me know if you're fine with the breaking changes or if you don't want to do those.

Sorry for the late response.

Based on your and @ilko-k's discussion, would it make more sense to add the Bear 2 as a new model without deleting or touching the Bear 3 model?

Yeah maybe, but if keeping it is decided, there are still things to correct (preview picture, brand name and printer name).

As for the Reborn 2, I own one so I could contribute for creating a new preset for it but I'll need someone to integrate it through github (I'm not familiar with PR and so)

@FlyingbearOfficial
Copy link
Contributor

FlyingbearOfficial commented May 22, 2024

Hello, this is flyingbear official, REBORN3 will be on sale soon, the REBORN3 and REBORN2 are not the same machine, please be aware of that! thank you @SoftFever @cochcoder @ilko-k

@SoftFever
Copy link
Owner

Hello, this is flyingbear official, REBORN3 will be on sale soon, the REBORN3 and REBORN2 are not the same machine, please be aware of that! thank you @SoftFever @cochcoder @ilko-k

Hi
👍
Feel free to work with our awesome community to fix/improve profiles

@cochcoder cochcoder closed this May 22, 2024
@cochcoder
Copy link
Contributor Author

Hello, this is flyingbear official, REBORN3 will be on sale soon, the REBORN3 and REBORN2 are not the same machine, please be aware of that! thank you @SoftFever @cochcoder @ilko-k

Thank you for reaching out and letting us know this

@cochcoder cochcoder deleted the Flying-Bear-Fixes branch May 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"FlyingBear Reborn3" is a mistake
5 participants