Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gcode preview navigation #5326

Merged
merged 2 commits into from May 19, 2024

Conversation

buzzhuzz
Copy link
Contributor

Description

This change improves gcode preview navigation:

  1. Added Home/End key actions in order to se horizontal (moves) slider to the start/end position respectively.
  2. Automatically switch to the next layer on pressing right at the last position of the layer. Same for the pressing left at the first position.

Screenshots/Recordings/Graphs

gcode-preview2.mp4

Tests

Manual testing only.
Community testers are welcome.

Add HOME and END key action to preview tab which moves horizontal slider
position to a first and last position respectively
Automatically advance gcode preview to the next layer when pressing
right at the last step of the layer. Same for the first step of the
layer: pressing 'left' will switch preview to the previous layer
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the new home and end hotkeys.

I have some mixed feelings about the new left/right arrow behavior, though. But I think it's worth giving it a bit more time to play around with the new behavior.

@SoftFever SoftFever merged commit 6369772 into SoftFever:main May 19, 2024
12 checks passed
@buzzhuzz buzzhuzz deleted the dbuzz/gcode-viewer-navigation branch May 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants