Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries and sonar.java.libraries are set #222

Merged
merged 3 commits into from
May 21, 2024

Conversation

alban-auzeill
Copy link
Member

No description provided.

@alban-auzeill alban-auzeill changed the title SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries and sonar.java.libraries is set SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries and sonar.java.libraries is set May 15, 2024
@alban-auzeill alban-auzeill force-pushed the alban/SCANMAVEN-216 branch 2 times, most recently from 9d0ec9c to ab51950 Compare May 15, 2024 13:35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on the right track but I think we can simplify a few things and make tests a little more explicit.

@alban-auzeill alban-auzeill changed the title SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries and sonar.java.libraries is set SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries and sonar.java.libraries are set May 17, 2024
@alban-auzeill alban-auzeill force-pushed the alban/SCANMAVEN-216 branch 2 times, most recently from 1c8208e to df150e4 Compare May 17, 2024 15:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I left a couple of small improvements that could help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿 Thanks for the changes!

@alban-auzeill alban-auzeill merged commit e3cc5ec into master May 21, 2024
18 checks passed
@alban-auzeill alban-auzeill deleted the alban/SCANMAVEN-216 branch May 21, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants