mention autocomplete does not trigger when there is an active selection #65
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx, I'll merge this one when I find the time. |
Kobee1203
pushed a commit
to jalios/tinyMCE-mention
that referenced
this pull request
Jan 25, 2018
… the delimiter. Refactoring to override the default behavior. New options: - triggerRegex: regex (string or RegExp object) to Allow autocomplete if the preceding text matches the trigger regex. The default allows autocomplete after punctuation characters or whitespaces - canTriggerAutocomplete: function which returns a boolean and indicate when the autocomplete is triggered. The default allows autocomplete : - when there is an active selection (see StevenDevooght#65) - when there are characters after the delimiter (new condition) - if the text preceding the delimiter matches the regex defined by 'triggerRegex'
Kobee1203
force-pushed
the
autocomplete_with_active_selection
branch
from
216d2db
to
5dedfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prevCharIsSpace() function doesn't check if there is a selected text. I added a new condition to check if there is a selected text.
I renamed this function to be consistent with what it does.