Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Non-blocking stylesheet resolving #320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stranger6667
Copy link
Owner

@Stranger6667 Stranger6667 commented Jan 1, 2024

Resolves #246

  • Use Atomic for tendrils during doc construction when necessary

Copy link

codspeed-hq bot commented Jan 1, 2024

CodSpeed Performance Report

Merging #320 will not alter performance

Comparing dd/async-resolver (1afd436) with master (a52171c)

Summary

✅ 6 untouched benchmarks

@Stranger6667 Stranger6667 force-pushed the dd/async-resolver branch 4 times, most recently from 1f63b36 to bf49213 Compare January 1, 2024 17:40
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (a52171c) 84.25% compared to head (1afd436) 81.84%.

Files Patch % Lines
css-inline/src/lib.rs 74.79% 31 Missing ⚠️
css-inline/src/resolver.rs 84.61% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   84.25%   81.84%   -2.41%     
==========================================
  Files          19       19              
  Lines        1791     1774      -17     
==========================================
- Hits         1509     1452      -57     
- Misses        282      322      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-blocking stylesheet resolving
1 participant