Fix segfault on attempting to use EditConfigValue() to edit a config …

…file on a readonly filesystem.
Subsentient · Feb 12, 2015 · 49db575 · 49db575 · Subsentient · Feb 12, 2015
1 parent 77b3460
commit 49db575
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/config.c b/src/config.c
@@ -2283,7 +2283,17 @@ ReturnCode EditConfigValue(const char *File, const char *ObjectID, const char *A
 	free(HalfTwo);
 
 	/*Write the configuration back to disk.*/
-	Descriptor = fopen(File, "w");
+	if (!(Descriptor = fopen(File, "w")))
+	{
+		char ErrBuf[2048];
+		snprintf(ErrBuf, sizeof ErrBuf, "Failed to edit attribute %s for object %s in file %s. File unchanged.",
+				Attribute, ObjectID, File);
+
+		SpitWarning(ErrBuf);
+		free(MasterStream);
+		return FAILURE;
+	}
+
 	fwrite(MasterStream, 1, strlen(MasterStream), Descriptor);
 	fclose(Descriptor);