Lazy-creation of output tables for ibis to enable auto-inference of o… #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
feat/auto-model-output
branch
from
b118c43
to
eec031f
Compare
jieguangzhou
force-pushed
the
feat/auto-model-output
branch
from
eec031f
to
688e7b4
Compare
blythed
reviewed
May 13, 2024
|
|
||
| Listener.create_output_dest(self.db, predict_id, self) | ||
|
|
||
| if self.datatype is not None and self.output_schema is not None: |
There was a problem hiding this comment.
Later will become db.apply(self) and will only update changed fields.
blythed
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2044
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments